samsam2610/experiments-database
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(backend): widen plot_config size cap to fit a full hiddenSubjects list

Browse Source 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Experiments DB Dev
2026-06-01 10:30:06 -04:00
parent 9a9b5dfae8
commit b0c6217cb4
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/routes/experiments.js
+4 -3
View File
@@ -224,9 +224,10 @@ function validateSubjectTemplate(template) {
return null; return null;
} }
// Upper bound on the stored UI-preference blob. Generous for the known fields; // Upper bound on the stored UI-preference blob. Sized to comfortably hold the known
// guards against a client persisting an arbitrarily large object. // fields plus a full hiddenSubjects list (≤500 UUIDs ≈ 20 KB) with headroom, while
const PLOT_CONFIG_MAX_BYTES = 16 * 1024; // still guarding against a client persisting an arbitrarily large object.
const PLOT_CONFIG_MAX_BYTES = 64 * 1024;
// The blob is intentionally schema-loose (clients may add display keys over time); // The blob is intentionally schema-loose (clients may add display keys over time);
// only hiddenSubjects is structurally validated since the backend reasons about it. // only hiddenSubjects is structurally validated since the backend reasons about it.
backend/tests/experiments.test.js
+1 -1
View File
@@ -176,7 +176,7 @@ describe('PUT /api/experiments/:id/plot-config', () => {
it('rejects an oversized config with 422', async () => { it('rejects an oversized config with 422', async () => {
prisma.experiment.findUnique.mockResolvedValue(EXPERIMENT); prisma.experiment.findUnique.mockResolvedValue(EXPERIMENT);
const big = { blob: 'x'.repeat(20000) }; const big = { blob: 'x'.repeat(70000) };
const res = await request(app).put(`/api/experiments/${EXPERIMENT.id}/plot-config`).send(big); const res = await request(app).put(`/api/experiments/${EXPERIMENT.id}/plot-config`).send(big);
expect(res.status).toBe(422); expect(res.status).toBe(422);
expect(prisma.experiment.update).not.toHaveBeenCalled(); expect(prisma.experiment.update).not.toHaveBeenCalled();